Verify command packages have the wheel extension applied#3230
Merged
derekbekoe merged 2 commits intoAzure:masterfrom May 8, 2017
Merged
Verify command packages have the wheel extension applied#3230derekbekoe merged 2 commits intoAzure:masterfrom
derekbekoe merged 2 commits intoAzure:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3230 +/- ##
==========================================
- Coverage 70.35% 70.27% -0.08%
==========================================
Files 381 391 +10
Lines 24777 25068 +291
Branches 3785 3811 +26
==========================================
+ Hits 17431 17617 +186
- Misses 6237 6342 +105
Partials 1109 1109
Continue to review full report at Codecov.
|
Member
Author
|
@johanste Does this look good to you? |
johanste
reviewed
May 8, 2017
| # STEP 4:: Verify the wheels that get produced | ||
| print_heading('Verifying wheels...') | ||
| invalid_wheels = [] | ||
| for wheel_path in glob.glob(built_packages_dir + '/*.whl'): |
Member
There was a problem hiding this comment.
Technically, using path.join is the right thing to do.
johanste
reviewed
May 8, 2017
Member
johanste
left a comment
There was a problem hiding this comment.
One minor nitpick. Other than that, looks good. You could consider printing which init.py file was included in the package, but that is not required (it's not that hard to crack open the wheel after all)
Member
Author
|
@johanste feedback addressed. |
johanste
approved these changes
May 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifies the following as part of CI:
A valid command module .whl for the CLI should:
Does the package have a azure_bdist_wheel.py file?
Does the package have a setup.cfg file?
Does setup.py include 'cmdclass=cmdclass'?
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)