Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
@yonzhan @evelyn-ys Please review this and get this merged ASAP |
az storage blob download-batch: Fix encoding str into byteaz storage blob download-batch: Fix encoding str into byte
az storage blob download-batch: Fix encoding str into byteaz storage blob download-batch/delete-batch: Fix incorrectly encoding str into byte
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes bugs in Azure CLI storage batch operations where strings were incorrectly being encoded to bytes, causing failures in blob download-batch and delete-batch commands. The fix removes unnecessary UTF-8 encoding logic and improves test coverage.
- Removes problematic UTF-8 encoding of blob names in the
collect_blob_objectsfunction - Refactors test structure to use
ScenarioTestinstead ofLiveScenarioTestfor better test reliability - Adds proper test isolation by using unique container names for each test scenario
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/storage/util.py | Removes unnecessary UTF-8 encoding logic that was causing string-to-byte conversion issues |
| src/azure-cli/azure/cli/command_modules/storage/tests/latest/test_storage_batch_operations.py | Refactors tests to use ScenarioTest, adds proper container isolation, and reorganizes test classes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+734
to
+738
| def create_and_populate_container(src_container): | ||
| self.storage_cmd('storage container create -n {}', storage_account_info, src_container) | ||
|
|
||
| # upload test files to storage account | ||
| self.storage_cmd('storage blob upload-batch -s "{}" -d {}', storage_account_info, test_dir, src_container) |
There was a problem hiding this comment.
[nitpick] The nested function create_and_populate_container is duplicated logic from the original test. Consider extracting this as a helper method of the test class to improve code reusability and maintainability.
jsntcy
approved these changes
Sep 12, 2025
This was referenced Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Fix #32039 #32091 #32088
Fixing incorrectly encoding a str into utf-8 which would make it a byte.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.