Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
7 tasks
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
jiasli
reviewed
Nov 15, 2024
src/azure-cli/azure/cli/command_modules/cdn/custom/custom_rule_util.py
Outdated
Show resolved
Hide resolved
jiasli
reviewed
Nov 15, 2024
src/azure-cli/azure/cli/command_modules/relay/tests/latest/test_relay_commands.py
Outdated
Show resolved
Hide resolved
jiasli
reviewed
Nov 15, 2024
| c.argument('nics', nargs='+', help='Names or IDs of existing NICs to attach to the VM. The first NIC will be designated as primary. If omitted, a new NIC will be created. If an existing NIC is specified, do not specify subnet, VNet, public IP or NSG.') | ||
| c.argument('private_ip_address', help='Static private IP address (e.g. 10.0.0.5).') | ||
| c.argument('public_ip_address', help='Name of the public IP address when creating one (default) or referencing an existing one. Can also reference an existing public IP by ID or specify "" for None (\'""\' in Azure CLI using PowerShell or --% operator). For Azure CLI using powershell core edition 7.3.4, specify '' or "" (--public-ip-address '' or --public-ip-address "")') | ||
| c.argument('public_ip_address', help='Name of the public IP address when creating one (default) or referencing an existing one. Can also reference an existing public IP by ID or specify "" for None (\'""\' in Azure CLI using PowerShell or --% operator). For Azure CLI using powershell core edition 7.3.4, specify or "" (--public-ip-address or --public-ip-address "")') |
Member
There was a problem hiding this comment.
Suggested change
| c.argument('public_ip_address', help='Name of the public IP address when creating one (default) or referencing an existing one. Can also reference an existing public IP by ID or specify "" for None (\'""\' in Azure CLI using PowerShell or --% operator). For Azure CLI using powershell core edition 7.3.4, specify or "" (--public-ip-address or --public-ip-address "")') | |
| c.argument('public_ip_address', help='Name of the public IP address when creating one (default) or referencing an existing one. Can also reference an existing public IP by ID or specify "" for None (\'""\' in Azure CLI using PowerShell or --% operator). For Azure CLI using powershell core edition 7.3.4, specify or "" (--public-ip-address or --public-ip-address "")') |
Contributor
Author
There was a problem hiding this comment.
The ' character is missing. The help message is also not correct. In powershell, the empty string shoule be represented as '""'.
bebound
commented
Nov 15, 2024
src/azure-cli/azure/cli/command_modules/relay/tests/latest/test_relay_commands.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jiashuo Li <4003950+jiasli@users.noreply.github.com>
3 tasks
bebound
commented
Nov 27, 2024
src/azure-cli/azure/cli/command_modules/synapse/manual/_params.py
Outdated
Show resolved
Hide resolved
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jiasli
reviewed
Nov 29, 2024
| c.argument('workload_profile_name', help="The name of the workload profile to run the app on.", is_preview=True) | ||
| c.argument('cpu', type=float, help="Required CPU in cores from 0.5 to 2.0.", is_preview=True) | ||
| c.argument('memory', help="Required momory from 1.0 to 4.0 ending with ""Gi"" e.g. 1.0Gi, ", is_preview=True) | ||
| c.argument('memory', help="Required momory from 1.0 to 4.0 ending with Gi e.g. 1.0Gi, ", is_preview=True) |
Member
There was a problem hiding this comment.
I guess the author wants to quote Gi:
Suggested change
| c.argument('memory', help="Required momory from 1.0 to 4.0 ending with Gi e.g. 1.0Gi, ", is_preview=True) | |
| c.argument('memory', help='Required momory from 1.0 to 4.0 ending with "Gi" e.g. 1.0Gi, ', is_preview=True) |
jiasli
reviewed
Nov 29, 2024
| "cache_key_query_string": { | ||
| "parameters": { | ||
| "type_name" "DeliveryRuleCacheKeyQueryStringBehaviorActionParameters" | ||
| "type_name": "DeliveryRuleCacheKeyQueryStringBehaviorActionParameters", |
Member
There was a problem hiding this comment.
Can't imagine how the code still works while it is as wrong as such.
jiasli
reviewed
Nov 29, 2024
| completer=get_providers_completion_list, | ||
| arg_group='Resource ID', | ||
| help='Provider namespace (Ex: ''Microsoft.Provider'').') | ||
| help='Provider namespace (Ex: Microsoft.Provider).') |
Member
There was a problem hiding this comment.
I think the author actually wants to quote Microsoft.Provider, but used the PowerShell syntax:
> echo "a""b"
a"b
> echo 'a''b'
a'b
Suggested change
| help='Provider namespace (Ex: Microsoft.Provider).') | |
| help="Provider namespace (Ex: 'Microsoft.Provider').") |
Member
There was a problem hiding this comment.
Should the following three help messages be kept consistent? Personally, I think when parentheses are used, having or not having double quotes is fine.
jiasli
approved these changes
Nov 29, 2024
Member
jiasli
left a comment
There was a problem hiding this comment.
Let's not assume what the author wants to quote. Just merge this PR and let the author change it in the future.
wangzelin007
approved these changes
Dec 3, 2024
zhoxing-ms
approved these changes
Dec 3, 2024
evelyn-ys
approved these changes
Dec 3, 2024
jsntcy
approved these changes
Dec 3, 2024
kairu-ms
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix this with
ruff check . --select ISC001 --fixsuperfluous-parens was disabled in #26685
Ref:
https://pylint.readthedocs.io/en/stable/user_guide/messages/warning/implicit-str-concat.html
https://docs.astral.sh/ruff/rules/single-line-implicit-string-concatenation/