Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
7 tasks
bebound
commented
Nov 18, 2024
| functionapp_def.workload_profile_name = workload_profile_name | ||
|
|
||
| if (cpu is not None and memory is not None): | ||
| if cpu is not None and memory is not None: |
Contributor
Author
There was a problem hiding this comment.
Pylint does not find this error, reported to pylint-dev/pylint#10084
jiasli
reviewed
Nov 20, 2024
| """ | ||
| Spawns a thread that waits for a bit then opens a URL. | ||
| """ | ||
| t = threading.Thread(target=wait_then_open, args=({url})) |
Member
There was a problem hiding this comment.
The ({url}) is actually a set. This is wrong.
jiasli
previously approved these changes
Nov 20, 2024
jiasli
previously approved these changes
Nov 29, 2024
wangzelin007
previously approved these changes
Dec 3, 2024
zhoxing-ms
previously approved these changes
Dec 3, 2024
evelyn-ys
previously approved these changes
Dec 3, 2024
jsntcy
previously approved these changes
Dec 3, 2024
kairu-ms
previously approved these changes
Dec 3, 2024
cbe7e00
wangzelin007
approved these changes
Dec 3, 2024
evelyn-ys
approved these changes
Dec 3, 2024
zhoxing-ms
approved these changes
Dec 3, 2024
kairu-ms
approved these changes
Dec 3, 2024
jsntcy
approved these changes
Dec 3, 2024
jiasli
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix this with
ruff check . --select UP034 --fixsuperfluous-parenswas disabled in #26685Ref:
https://pylint.readthedocs.io/en/stable/user_guide/messages/convention/superfluous-parens.html
https://docs.astral.sh/ruff/rules/extraneous-parentheses/
astral-sh/ruff#970