Skip to content

login: fix a failure when login twice using the same sp#2848

Merged
yugangw-msft merged 2 commits intoAzure:masterfrom
yugangw-msft:splogin
Apr 13, 2017
Merged

login: fix a failure when login twice using the same sp#2848
yugangw-msft merged 2 commits intoAzure:masterfrom
yugangw-msft:splogin

Conversation

@yugangw-msft
Copy link
Copy Markdown
Contributor

@yugangw-msft yugangw-msft commented Apr 12, 2017

fix #2800

General Guidelines

  • The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

- [ ] Each command and parameter has a meaningful description.
- [ ] Each new command has a test.

(see Authoring Command Modules)

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 12, 2017

Codecov Report

Merging #2848 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2848      +/-   ##
==========================================
+ Coverage   62.92%   62.94%   +0.01%     
==========================================
  Files         464      464              
  Lines       25899    25899              
  Branches     3943     3943              
==========================================
+ Hits        16298    16302       +4     
+ Misses       8567     8563       -4     
  Partials     1034     1034
Impacted Files Coverage Δ
src/azure-cli-core/azure/cli/core/_profile.py 85.25% <100%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6b3c18...cee3d84. Read the comment docs.

@yugangw-msft yugangw-msft changed the title login: fix a bug on login through sp login: fix a failure when login twice using the same sp Apr 13, 2017
@yugangw-msft yugangw-msft requested a review from derekbekoe April 13, 2017 15:49
@derekbekoe
Copy link
Copy Markdown
Member

This also fixes test_get_expanded_subscription_info_for_logged_in_service_principal from #2760

@yugangw-msft yugangw-msft merged commit a659872 into Azure:master Apr 13, 2017
@yugangw-msft yugangw-msft deleted the splogin branch April 13, 2017 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants