[Network] Fix Traffic Manager type handling #2844
Merged
tjprescott merged 1 commit intoAzure:masterfrom Apr 12, 2017
tjprescott:FixTrafficManagerType
Merged
[Network] Fix Traffic Manager type handling #2844tjprescott merged 1 commit intoAzure:masterfrom tjprescott:FixTrafficManagerType
tjprescott merged 1 commit intoAzure:masterfrom
tjprescott:FixTrafficManagerType
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2844 +/- ##
==========================================
+ Coverage 62.88% 62.92% +0.04%
==========================================
Files 464 464
Lines 25901 25899 -2
Branches 3944 3943 -1
==========================================
+ Hits 16288 16298 +10
+ Misses 8594 8567 -27
- Partials 1019 1034 +15
Continue to review full report at Codecov.
|
troydai
approved these changes
Apr 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2839. Clarifies that
--typeis a required part of the endpoint ID and no longer attempts to update the endpoint type inaz traffic-manager endpoint update. Adds test coverage for all traffic manager commands.This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)