[Network] VPN-connection shared key fixes#2798
Merged
tjprescott merged 2 commits intoAzure:masterfrom Apr 7, 2017
tjprescott:SharedKeyFixes
Merged
[Network] VPN-connection shared key fixes#2798tjprescott merged 2 commits intoAzure:masterfrom tjprescott:SharedKeyFixes
tjprescott merged 2 commits intoAzure:masterfrom
tjprescott:SharedKeyFixes
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2798 +/- ##
=========================================
+ Coverage 62.89% 62.9% +<.01%
=========================================
Files 480 480
Lines 25998 26003 +5
Branches 3943 3944 +1
=========================================
+ Hits 16352 16356 +4
- Misses 8618 8619 +1
Partials 1028 1028
Continue to review full report at Codecov.
|
yugangw-msft
approved these changes
Apr 7, 2017
| null_props = [key for key in prop_val.__dict__ if not prop_val.__dict__[key]] | ||
| for prop in null_props: | ||
| delattr(prop_val, prop) | ||
| if result: |
Contributor
There was a problem hiding this comment.
Unless I missed something subtle, I don't see this condition is needed to address the involved issue.
Member
Author
There was a problem hiding this comment.
You are correct--it was needed for another issue I discovered whilst fixing these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1602.
Adds test coverage for the previously not covered
vpn-connection shared-keycommands. Fixes the output of the vpn-connection create command, which previously exposed the deployment "wrapping". This is technically a breaking change (and called out as such in the HISTORY).This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)