[Network] Convert network creates to use SDK#2371
Merged
tjprescott merged 9 commits intoAzure:masterfrom Mar 3, 2017
tjprescott:ConvertNetworkCreates
Merged
[Network] Convert network creates to use SDK#2371tjprescott merged 9 commits intoAzure:masterfrom tjprescott:ConvertNetworkCreates
tjprescott merged 9 commits intoAzure:masterfrom
tjprescott:ConvertNetworkCreates
Conversation
10 tasks
…scott/azure-cli into ConvertNetworkCreates
Codecov Report
@@ Coverage Diff @@
## master #2371 +/- ##
==========================================
- Coverage 72.93% 72.24% -0.69%
==========================================
Files 425 323 -102
Lines 19310 18086 -1224
Branches 2741 2650 -91
==========================================
- Hits 14083 13067 -1016
+ Misses 4323 4196 -127
+ Partials 904 823 -81
Continue to review full report at Codecov.
|
yugangw-msft
approved these changes
Mar 3, 2017
| register_cli_argument('network nic create', 'network_interface_name', nic_type, options_list=('--name', '-n'), id_part=None, validator=process_nic_create_namespace) | ||
| register_cli_argument('network nic create', 'private_ip_address_allocation', ignore_type) | ||
| register_cli_argument('network nic create', 'use_dns_settings', ignore_type) | ||
| register_cli_argument('network nic create', 'private_ip_address_version', help='The private IP address version to use.') |
Contributor
There was a problem hiding this comment.
I assume we will still have the choices ['ipv4', 'ipv6'] for this arg
| ns.create_client_configuration = any(ns.address_prefixes or []) | ||
| if ns.enable_bgp and not ns.asn: | ||
| validate_location(ns) | ||
| enable_bgp = any([ns.asn or ns.bgp_peering_address or ns.peer_weight]) |
Contributor
There was a problem hiding this comment.
i think the any is not being used, rather it should be any([ns.asn, ns.bgp_peering_address, ns.peer_weight])?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the following network creates from the old "fat client" implementation to simply use the SDK: