[Network] Convert VNet Create to use SDK#2269
Merged
tjprescott merged 4 commits intoAzure:masterfrom Mar 1, 2017
tjprescott:ConvertVnetCreate
Merged
[Network] Convert VNet Create to use SDK#2269tjprescott merged 4 commits intoAzure:masterfrom tjprescott:ConvertVnetCreate
tjprescott merged 4 commits intoAzure:masterfrom
tjprescott:ConvertVnetCreate
Conversation
10 tasks
Codecov Report
@@ Coverage Diff @@
## master #2269 +/- ##
==========================================
- Coverage 72.95% 72.92% -0.03%
==========================================
Files 458 441 -17
Lines 19499 19308 -191
Branches 2578 2730 +152
==========================================
- Hits 14226 14081 -145
+ Misses 4390 4305 -85
- Partials 883 922 +39
Continue to review full report at Codecov.
|
yugangw-msft
approved these changes
Feb 27, 2017
Contributor
There was a problem hiding this comment.
I think required=True is unnecessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2073 (allows multiple address-prefixes for create). Also partially addresses #2198 in that it converts the "FatClient" to use the SDK. There's no need to dynamically generate a template for this command.
The breaking change is the old output format was:
"newVNet": { VNET object }
and now we simply return the VNET object with no need to index on "newVNet".The resulting object is manually wrapped in "newVNet" so as not to cause a breaking change. This will be removed at the next opportunity of a networking API change.