{Packaging} Bump azure-core from 1.21.1 to 1.24.0#22676
Merged
Conversation
Collaborator
|
Packaging |
…-azure-core � Conflicts: � src/azure-cli/azure/cli/command_modules/network/tests/latest/recordings/test_network_public_ip_prefix.yaml
…re-cli into upgrade-azure-core
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jsntcy
approved these changes
Jun 7, 2022
jsntcy
reviewed
Jun 7, 2022
| @@ -1406,12 +1406,13 @@ def test_sql_pool(self): | |||
| self.cmd('az synapse sql pool show --name {sql-pool} --workspace {workspace} --resource-group {rg}', | |||
| expect_failure=True) | |||
|
|
|||
| @record_only() | |||
| @unittest.skip('Resource group \'rgtesting\' could not be found') | |||
Member
There was a problem hiding this comment.
Skip it temporarily as we cannot pass test lively as the test used fixed resources, will contact service team to fix it later.
jsntcy
reviewed
Jun 7, 2022
| @@ -2629,6 +2630,7 @@ def test_notebook(self): | |||
| 'az synapse notebook show --workspace-name {workspace} --name {name}', | |||
| expect_failure=True) | |||
|
|
|||
| @unittest.skip('UnicodeDecodeError') | |||
Member
There was a problem hiding this comment.
Skip it temporarily as we cannot pass test lively as the test used corrupted file that cannot be decoded, will contact service team to fix it later.
zhoxing-ms
reviewed
Jun 7, 2022
| # kwargs for string formatting | ||
| aks_name = self.create_random_name('cliakstest', 16) | ||
| kubernetes_version = "1.20.7" | ||
| kubernetes_version = "1.23.5" |
Contributor
There was a problem hiding this comment.
Just of curiosity, may I ask why do we need to upgrade this kubernetes_version ?
Contributor
Author
There was a problem hiding this comment.
Because version 1.20.7 is not currently supported in this region.
zhoxing-ms
reviewed
Jun 7, 2022
…-azure-core � Conflicts: � src/azure-cli/azure/cli/command_modules/servicefabric/tests/latest/recordings/test_basic_cluster.yaml � src/azure-cli/azure/cli/command_modules/servicefabric/tests/latest/test_sf_managed_cluster.py
3 tasks
evelyn-ys
approved these changes
Jun 9, 2022
kairu-ms
approved these changes
Jun 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Some modules (#22486) and extensions (AML) which use new SDK need newer version of azure-core, so we need upgrade it to the latest version (1.24.0).
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.