[Compute] az sig image-version create: Add new parameters --virtual-machine and --image-version to support creating image version from different source#22645
Merged
zhoxing-ms merged 5 commits intoAzure:devfrom Jun 1, 2022
Conversation
…d, and style check is not proceeded
az sig image-version create --managed-image: Update argument for different source (#22424)az sig image-version create: Add new parameters --virtual-machine and --image-version to support creating image version from different source
zhoxing-ms
reviewed
May 27, 2022
zhoxing-ms
reviewed
May 27, 2022
zhoxing-ms
reviewed
May 27, 2022
zhoxing-ms
reviewed
May 27, 2022
Collaborator
|
@yanzhudd good beginning:) |
…ype whether correct
Contributor
Author
Thanks:) |
zhoxing-ms
reviewed
Jun 1, 2022
| for scope in ['sig image-version create', 'sig image-version update']: | ||
| with self.argument_context(scope) as c: | ||
| c.argument('target_regions', nargs='*', validator=process_gallery_image_version_namespace, |
Contributor
There was a problem hiding this comment.
Since command sig image-version update also called validator=process_gallery_image_version_namespace, we may add a command level validator for command sig image-version update, and then call process_gallery_image_version_namespace in the command level validator
zhoxing-ms
approved these changes
Jun 1, 2022
Contributor
|
Nice work! 🎉 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add new parameters
--virtual-machineand--image-versionto support creating image version from different sourceClose #22424
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.