Skip to content

{local-context} Remove local-context command group#22471

Merged
jiasli merged 3 commits intoAzure:devfrom
jiasli:local-context
May 19, 2022
Merged

{local-context} Remove local-context command group#22471
jiasli merged 3 commits intoAzure:devfrom
jiasli:local-context

Conversation

@jiasli
Copy link
Copy Markdown
Member

@jiasli jiasli commented May 16, 2022 •
edited
Loading

Related command
az local-context

Description

az local-context command group introduced by #13277 has been replaced by az config param-persist (#15068).

> az -h

Group
    az

Subgroups:
    ...
    local-context [Deprecated] [Experimental] : Manage Local Context.

> az local-context -h

Group
    az local-context : Manage Local Context.
        This command group has been deprecated and will be removed in future release. Use
        'config param-persist' instead.
        This command group is experimental and under development. Reference and support levels:
        https://aka.ms/CLI_refstatus

The test for local-context frequently causes CI failure after parallel test is enabled (#22047):

https://dev.azure.com/azure-sdk/public/_build/results?buildId=1570457&view=logs&j=15e5eb7c-cf66-5b91-00a2-db9b11b5e0f9&t=845fa2ee-a602-59f5-4e4c-07ee6d0283b9&l=13132

                        if self._strict and sectname in elements_added:
>                           raise DuplicateSectionError(sectname, fpname,
                                                        lineno)
E                           configparser.DuplicateSectionError: While reading from '/home/vsts/.azure/config' [line 30]: section 'test_section2' already exists

/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/configparser.py:1070: DuplicateSectionError
...
=========================== short test summary info ============================
ERROR src/azure-cli/azure/cli/command_modules/configure/tests/latest/test_configure.py::LocalContextCommandsScenarioTest::test_local_context_commands

This PR removes the deprecated local-context command group.

@jiasli jiasli requested review from jsntcy and kairu-ms as code owners May 16, 2022 15:10
@jiasli jiasli requested a review from yonzhan May 16, 2022 15:12
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented May 16, 2022

local-context

@jiasli
Copy link
Copy Markdown
Member Author

jiasli commented May 17, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented May 17, 2022

Azure Pipelines successfully started running 2 pipeline(s).

@jiasli
Merge remote-tracking branch 'azure/dev' into local-context
f4d79d3 
# Conflicts:
#	src/azure-cli/azure/cli/command_modules/rdbms/tests/latest/test_rdbms_flexible_commands.py
@jiasli jiasli merged commit d618065 into Azure:dev May 19, 2022
@jiasli jiasli deleted the local-context branch May 19, 2022 02:44
@jiasli jiasli mentioned this pull request Nov 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evelyn-ys evelyn-ys evelyn-ys approved these changes

@jsntcy jsntcy jsntcy approved these changes

@wangzelin007 wangzelin007 wangzelin007 approved these changes

@yonzhan yonzhan yonzhan approved these changes

@kairu-ms kairu-ms kairu-ms approved these changes

@calvinhzy calvinhzy Awaiting requested review from calvinhzy calvinhzy is a code owner

+1 more reviewer

@DaeunYim DaeunYim DaeunYim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jiasli jiasli

Labels

None yet

Projects

None yet

Milestone

May 2022 (2022-05-24) - For Build

Development

Successfully merging this pull request may close these issues.

7 participants

@jiasli @yonzhan @evelyn-ys @jsntcy @wangzelin007 @kairu-ms @DaeunYim