{Compute} az vmss create: Add hint to suggest Standard lb#22340
Merged
zhoxing-ms merged 4 commits intoAzure:devfrom May 18, 2022
Merged
{Compute} az vmss create: Add hint to suggest Standard lb#22340zhoxing-ms merged 4 commits intoAzure:devfrom
az vmss create: Add hint to suggest Standard lb#22340zhoxing-ms merged 4 commits intoAzure:devfrom
Conversation
Collaborator
|
Compute |
vmss create add hint to suggest Standard lbaz vmss create: Add hint to suggest Standard lb
zhoxing-ms
reviewed
May 13, 2022
Comment on lines
+2889
to
+2891
| # In the latest profile, the default lb will be expected to be changed from Basic to Standard. | ||
| # In order to avoid breaking change which has a big impact to users, | ||
| # we use the hint to guide users to use Standard lb to create VMSS in the first stage. |
Contributor
There was a problem hiding this comment.
@thisisanniefang Could you help confirm that we only need to add this warning in the latest profile for public cloud?
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
wangzelin007
approved these changes
May 17, 2022
zhoxing-ms
reviewed
May 18, 2022
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
zhoxing-ms
approved these changes
May 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Fix: #22322
Add hint for
az vmss createThe default lb will be expected to be changed from Basic to Standard. In order to avoid big impact to users, we use the hint to guide users to use Standard lb to create VMSS in the first stage.
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.