[App Service] az staticwebapp create: Allow creating Static Web Apps not connected to a github repo#22042
Merged
zhoxing-ms merged 1 commit intoAzure:devfrom Apr 13, 2022
Merged
Conversation
Collaborator
|
App Service |
Contributor
|
@anthonychu & @simonaco FYI |
panchagnula
reviewed
Apr 13, 2022
|
|
||
| def create_staticsites(cmd, resource_group_name, name, location, # pylint: disable=too-many-locals, | ||
| source, branch, token=None, | ||
| def create_staticsites(cmd, resource_group_name, name, location="centralus", # pylint: disable=too-many-locals, |
Contributor
There was a problem hiding this comment.
Did we want to make location optional & Default to CentralUs?
Member
There was a problem hiding this comment.
Did we want to make location optional & Default to CentralUs?
Hi StrawnSC,
Can you confirm with this ?
Contributor
Author
There was a problem hiding this comment.
Yes, this is what @simonaco put on the ADO work item
panchagnula
approved these changes
Apr 13, 2022
Contributor
panchagnula
left a comment
There was a problem hiding this comment.
LGTM . Given there is no need for GitHub integration we can probably create a test case for empty SWA
az staticwebapp create: Allow creating Static Web Apps not connected to a github repo az staticwebapp create: Allow creating Static Web Apps not connected to a github repo
wangzelin007
approved these changes
Apr 13, 2022
zhoxing-ms
approved these changes
Apr 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #21058
Testing Guide
az staticwebapp create -g {} -n {}History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.