Skip to content

{Compute} az vmss create --orchestration-mode flexible: fix converting --edge-zone to template json #21992

Merged
zhoxing-ms merged 1 commit intoAzure:devfrom
cxznmhdcxz:issue21793
Apr 20, 2022
Merged

{Compute} az vmss create --orchestration-mode flexible: fix converting --edge-zone to template json #21992
zhoxing-ms merged 1 commit intoAzure:devfrom
cxznmhdcxz:issue21793

Conversation

@cxznmhdcxz
Copy link
Copy Markdown
Member

@cxznmhdcxz cxznmhdcxz commented Apr 8, 2022

Description
Fix: #21793

There are two problems with this issue:

  1. --edge-zone parameter is not converted through validate_edge_zone, resulting in the following InvalidTemplate error reports:
{"error":{"code":"InvalidTemplate","message":"Deployment template parse failed: 'Error converting value "microsoftrrdclab1" to type 'Azure.Deployments.Core.Definitions.Resources.ResourceExtendedLocation'. Path ''.'."}}

This PR is used to fix this problem

  1. After fixing the first problem, an error will still occur because creating Flex VMSS still does not support edge zone
{"code":"BadRequest","message":"{ "error": { "code": "InvalidParameter", "message": "Parameter 'extendedLocation' is not allowed.", "target": "extendedLocation" }}}

We have confirmed with the Flex VMSS team @fitzgeraldsteele to keep this behavior and error message first, and wait for the subsequent support from service in Cu semester comment link

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost requested a review from yonzhan April 8, 2022 10:12
@ghost ghost added the Auto-Assign Auto assign by bot label Apr 8, 2022
@ghost ghost assigned zhoxing-ms Apr 8, 2022
@ghost ghost added this to the Apr 2022 (2022-04-26) milestone Apr 8, 2022
@ghost ghost added the Compute az vm/vmss/image/disk/snapshot label Apr 8, 2022
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Apr 8, 2022

Compute

Copy link
Copy Markdown
Member

@wangzelin007 wangzelin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for parameter --edge-zone ?

@cxznmhdcxz
Copy link
Copy Markdown
Member Author

Can we add a test for parameter --edge-zone ?

Flexible VMSS doesn't support edge zone yet. There exists a test for uniform VMSS --edge-zone.

Copy link
Copy Markdown
Contributor

@zhoxing-ms zhoxing-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangzelin007 I have updated the PR description to specifically explain the background of this PR. Please help review it again

@zhoxing-ms zhoxing-ms merged commit 0dfd602 into Azure:dev Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Compute az vm/vmss/image/disk/snapshot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"az vmss create" for FLEX does not convert "--edge-zone" to "extendedLocation" in template

4 participants