Conversation
Collaborator
|
Storage |
az storage container policy create\update\list\show\delete: Migrate to track2 sdkaz storage container policy create\update\list\show\delete: Add new permissions which is now racwdxyltmei, Migrate to track2 sdk
az storage container policy create\update\list\show\delete: Add new permissions which is now racwdxyltmei, Migrate to track2 sdkaz storage container policy create\update\list\show\delete: Add new permissions which is now racwdxyltfmei, Migrate to track2 sdk
az storage container policy create\update\list\show\delete: Add new permissions which is now racwdxyltfmei, Migrate to track2 sdkaz storage container policy create\update\list\show\delete: Add new permissions, currently racwdxyltfmei, Migrate to track2 sdk
az storage container policy create\update\list\show\delete: Add new permissions, currently racwdxyltfmei, Migrate to track2 sdkaz storage container policy create\update\list\show\delete: Add new permissions, currently racwdxyltmei, Migrate to track2 sdk
az storage container policy create\update\list\show\delete: Add new permissions, currently racwdxyltmei, Migrate to track2 sdkaz storage container policy create\update\list\show\delete: Add new permissions, currently racwdxylftmei, Migrate to track2 sdk
az storage container policy create\update\list\show\delete: Add new permissions, currently racwdxylftmei, Migrate to track2 sdkaz storage container policy create\update\list\show\delete: Add new permissions, currently racwdxyltmei, Migrate to track2 sdk
evelyn-ys
reviewed
Jun 7, 2022
Member
evelyn-ys
left a comment
There was a problem hiding this comment.
You only need to transform the result of _get_acl() then all other functions don't need to change anything
src/azure-cli/azure/cli/command_modules/storage/operations/access_policy.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/storage/operations/access_policy.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/storage/operations/access_policy.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/storage/operations/access_policy.py
Outdated
Show resolved
Hide resolved
evelyn-ys
reviewed
Jun 7, 2022
src/azure-cli/azure/cli/command_modules/storage/operations/access_policy.py
Outdated
Show resolved
Hide resolved
evelyn-ys
approved these changes
Jun 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #20452
Add new permissions, currently:
(a)dd (c)reate (d)elete (e)xecute (f)ilter_by_tags (i)set_immutability_policy (l)ist (m)ove (r)ead (t)ag (w)rite (x)delete_previous_version (y)permanent_delete
(f) currently not supported for all regions.
Testing Guide
az storage container policy create -c {container_name} -n {policy_name} --expiry {timestamp} --permissions racwdxyltfmeiaz storage container policy show -c {container_name} -n {policy_name}az storage container policy update -c {container_name} -n {policy_name} --permissions rwdxl --start {timestamp} --expiry {timestamp}az storage container policy list -c {container_name}az storage container policy delete -c {container_name} -n {policy_name}History Notes
[Storage] Fix #20452:
az storage container policy create\update\list\show\delete: Add new permissions, currently supportracwdxyltmeiThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.