Merged
Conversation
Collaborator
|
CI |
93f68e9 to
ced4800
Compare
ced4800 to
92e4524
Compare
3 tasks
jiasli
reviewed
Apr 12, 2022
| # 10 minutes. Unforunately there's no way to speed this up | ||
| while db['earliestRestoreDate'] is None: | ||
| sleep(60) | ||
| time.sleep(60) |
Member
There was a problem hiding this comment.
from time import sleep can now be removed.
Member
Author
There was a problem hiding this comment.
We need modify these codes before remove from time import sleep.
I think add if self.is_live condition is also acceptable.
Member
There was a problem hiding this comment.
Let's only remove from time import sleep when it is not used.
jiasli
reviewed
Apr 12, 2022
src/azure-cli/azure/cli/command_modules/resource/tests/latest/test_resource.py
Outdated
Show resolved
Hide resolved
kairu-ms
approved these changes
Apr 12, 2022
evelyn-ys
approved these changes
Apr 12, 2022
necusjz
approved these changes
Apr 12, 2022
zhoxing-ms
approved these changes
Apr 12, 2022
jiasli
approved these changes
Apr 12, 2022
calvinhzy
approved these changes
Apr 12, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR will speed up our test.
Our list command is not pagination, it will get all the data.
That is why some recording files are very large.
And in test_show_built_in_policy, we choose to check the first resource instead of check all the resource to speed up.
We only mock time.sleep in azure-sdk-tools.
That's why if someone use sleep(xxx), it will not work.
azure-cli/src/azure-cli-testsdk/azure/cli/testsdk/scenario_tests/patches.py
Line 13 in 30216d0
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.