Skip to content

[Compute ]Add new parameter community-gallery-info and --permission Community options to az sig create, add new command az sig share enable-community#20046

Closed
Jing-song wants to merge 7 commits intoAzure:devfrom
Jing-song:jings-19882
Closed

Conversation

@Jing-song
Copy link
Copy Markdown
Contributor

@Jing-song Jing-song commented Oct 26, 2021

Description

  1. create a gallery with community sharing info: az sig create --gallery-name --community-gallery-info publisherUri,publisherEmail,eual,publicNamePrefix
  2. share a gallery to community: az sig share enable-community
    Community Gallery CLI extension request #19882

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@Jing-song Jing-song self-assigned this Oct 26, 2021
@Jing-song Jing-song linked an issue Oct 26, 2021 that may be closed by this pull request
@Jing-song Jing-song changed the title [Compute ]Add new parameter community-gallery-info to az sig create, add new options community to 'az sig create --permissions' [Compute ]Add new parameter community-gallery-info to az sig create, add new options community to az sig create --permissions Oct 26, 2021
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Oct 26, 2021

Compute

@Jing-song Jing-song changed the title [Compute ]Add new parameter community-gallery-info to az sig create, add new options community to az sig create --permissions [Compute ]Add new parameter community-gallery-info to az sig create, add new command az sig share enable-community Oct 29, 2021
@Jing-song Jing-song changed the title [Compute ]Add new parameter community-gallery-info to az sig create, add new command az sig share enable-community [Compute ]Add new parameter community-gallery-info and --permission Community options to az sig create, add new command az sig share enable-community Oct 29, 2021
Comment on lines +1011 to +1012
c.argument('op_type', default='EnableCommunity', deprecate_info=c.deprecate(hide=True),
help='distinguish add operation and remove operation')
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this parameter?

Copy link
Copy Markdown
Contributor Author

@Jing-song Jing-song Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a required parameter of SharingUpdate, when using sig share enable-community, we need to fill in this parameter. The default value is EnableCommunity.

@zhoxing-ms
Copy link
Copy Markdown
Contributor

This PR is included by #20129, so close this one

@zhoxing-ms zhoxing-ms closed this Nov 1, 2021
@Jing-song Jing-song deleted the jings-19882 branch July 5, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Community Gallery CLI extension request

3 participants