[App Service] BREAKING CHANGE: az functionapp devops-pipeline: Remove commands and move them to functionapp extension#19716
Merged
zhoxing-ms merged 3 commits intoAzure:devfrom Oct 28, 2021
Conversation
3 tasks
Collaborator
|
functionapp |
az functionapp devops-pipeline: Remove commands and move them to extension.
az functionapp devops-pipeline: Remove commands and move them to extension.az functionapp devops-pipeline: Remove commands and move them to extension
az functionapp devops-pipeline: Remove commands and move them to extensionaz functionapp devops-pipeline: Remove commands and move them to functionapp extension
zhoxing-ms
approved these changes
Oct 27, 2021
zhoxing-ms
requested changes
Oct 27, 2021
Contributor
zhoxing-ms
left a comment
There was a problem hiding this comment.
Do we need to remove the dependency from setup.py:
azure-cli/src/azure-cli/setup.py
Line 59 in dd44b35
904f305 to
fee5dd2
Compare
Member
Author
|
@zhoxing-ms Sorry, didn't notice that one. Should be fixed now! |
zhoxing-ms
approved these changes
Oct 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change was requested by the CLI team (#18228) to reduce the CLI's install size. This PR is in conjunction with one in the extensions repo where the command will be moved (here)
Testing Guide
All tests related to this command were moved to the extension.
History Notes
[functionapp] BREAKING CHANGE: az functionapp devops-pipeline: Removed command. Moved to extension.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.