Skip to content

{AKS} create ssh-key in advance when perform concurrent tests#19190

Merged
zhoxing-ms merged 3 commits intoAzure:devfrom
FumingZhang:fuming/acs-ssh-key
Aug 13, 2021
Merged

{AKS} create ssh-key in advance when perform concurrent tests#19190
zhoxing-ms merged 3 commits intoAzure:devfrom
FumingZhang:fuming/acs-ssh-key

Conversation

@FumingZhang
Copy link
Copy Markdown
Member

@FumingZhang FumingZhang commented Aug 11, 2021

Description

Create ssh-key in advance to avoid the race condition that is prone to occur when key creation is handled by azure-cli when performing test cases concurrently.

For more details, please refer to issue #18854.

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Aug 11, 2021

AKS

@FumingZhang FumingZhang marked this pull request as ready for review August 12, 2021 09:14
@FumingZhang FumingZhang requested a review from Juliehzl as a code owner August 12, 2021 09:15
@FumingZhang
Copy link
Copy Markdown
Member Author

Fully tested, able to merge.

@zhoxing-ms zhoxing-ms merged commit fbc88d9 into Azure:dev Aug 13, 2021
@FumingZhang FumingZhang deleted the fuming/acs-ssh-key branch August 20, 2021 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants