Conversation
Collaborator
|
appservice |
panchagnula
reviewed
Aug 11, 2021
Contributor
There was a problem hiding this comment.
we need to make the same updates for functional config set as well.
panchagnula
reviewed
Aug 11, 2021
Contributor
There was a problem hiding this comment.
@seligj95 can you review the text & provide the blob you'd like to use here in the help. Thanks!
panchagnula
reviewed
Aug 11, 2021
Contributor
panchagnula
left a comment
There was a problem hiding this comment.
LGTM - but lets wait for text review from PM & incase he wants to update this.
seligj95
reviewed
Aug 11, 2021
Contributor
There was a problem hiding this comment.
can we add that you have to use the path to the file? it's probably obvious to most people, but just adding the bold below could help.
for PowerShell users, set configuration through a JSON file called params.json which is located in the current working directory
seligj95
reviewed
Aug 11, 2021
Contributor
seligj95
left a comment
There was a problem hiding this comment.
left a comment for review
…ig set' and 'az functionapp config set'
775c066 to
dcf3d6b
Compare
seligj95
approved these changes
Aug 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds additional examples to the help text for the command
az webapp config setto help PowerShell users properly use the--generic-configurationsoption. PowerShell apparently requires more strict usage of escape characters than bash, so PowerShell users were having issues when trying to pass in JSON via this command. The new help text clarifies that PowerShell users must escape the double quotes in their JSON with a backslash (or pass in a JSON file name).Testing Guide
Generate the relevant help text with
az webapp config set --helpHistory Notes
N/A
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.