[AKS] Fix incorrectly passed parameter for option --assign-kubelet-identity in aks create sub-command#19157
Merged
zhoxing-ms merged 1 commit intoAzure:devfrom Aug 11, 2021
Conversation
Collaborator
|
AKS |
Contributor
|
@FumingZhang May I ask why hasn't this issue been found in the test before? Could you add some test cases for it? |
Contributor
|
Please specify the related commands and parameters in the PR title~ |
Member
Author
|
We do have a test case (test_aks_custom_kubelet_identity) for this command/option , but it's tagged with @live_only. So the check-in pipeline, which only runs in recording mode could not find this issue. The issue was found by the azcli aks runner, which performs live tests periodically. |
Contributor
|
Could you describe in detail what |
Member
Author
I mean the |
andyliuliming
approved these changes
Aug 10, 2021
--assign-kubelet-identity in aks create sub-command
zhoxing-ms
approved these changes
Aug 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug Fix. Fix incorrectly passed parameter in function "_ensure_cluster_identity_permission_on_kubelet_identity", which affects the use of custom kubelet identity. The cause of the error is the function signature change introduced by PR#18443.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.