Conversation
|
Thank you for your contribution cpj2195! We will review the pull request and get back to you soon. |
|
|
|
RDBMS |
| c.argument('migration_id', arg_type=migration_id_arg_type, options_list=['--migration-id'], | ||
| help='Name or ID of the migration.') | ||
| c.argument('migration_name', arg_type=migration_id_arg_type, options_list=['--migration-name'], | ||
| help='Name of the migration.') |
There was a problem hiding this comment.
Can you query name out of the provided id? It's better to not cause breaking change for CX. Both id and name are supported before.
If only name is valid input, can it still be named --migration-id in param definition but migration_name in custom function?
There was a problem hiding this comment.
it will have to be migration_name because we are already using migration_id in the server-side code for internal identification in this migration workflow. The changes have already been shipped for this. Although, the migration_name can accept any strings(read guid's).
There was a problem hiding this comment.
It's a breaking change for cx's existing scripts.
I can help merge if you insist
az postgres flexible-server migration: Rename --migration-id to --migration-name
Description
Changed --migration-id parameter to migration-name in az postgres flexible-server migration [create, show, update, delete]
Changed test recordings file name to follow the naming convention
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.