[App Service] Fix #18497: functionapp identity show: Fix the crashes when the functionapp name does not reference an existing functionapp#19127
Merged
zhoxing-ms merged 6 commits intoAzure:devfrom Aug 11, 2021
Conversation
Collaborator
|
AppService |
panchagnula
reviewed
Aug 5, 2021
panchagnula
suggested changes
Aug 5, 2021
Contributor
panchagnula
left a comment
There was a problem hiding this comment.
just a few comments.
Contributor
|
Because this is a bug fix, it should be added to the release note, so the PR title needs to start with |
functionapp identity show: Fix the crashes when the functionapp name does not reference an existing functionapp
zhoxing-ms
reviewed
Aug 10, 2021
functionapp identity show: Fix the crashes when the functionapp name does not reference an existing functionappfunctionapp identity show: Fix the crashes when the functionapp name does not reference an existing functionapp
panchagnula
suggested changes
Aug 10, 2021
Contributor
panchagnula
left a comment
There was a problem hiding this comment.
Just one more nit comment - otherwise looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #18497
az functionapp identity show -n [non-existent functionapp name]was failing because identity was being extracted before checking for None.Testing Guide
Tested with non-existent functionapp name. Now returns error message "No identity to show for function app".
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.