{AKS} Update test related command output#19115
Merged
zhoxing-ms merged 8 commits intoAzure:devfrom Aug 11, 2021
Merged
Conversation
Collaborator
|
AKS |
andyliuliming
suggested changes
Aug 4, 2021
9c1a437 to
1cea26e
Compare
andyliuliming
suggested changes
Aug 6, 2021
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
zhoxing-ms
reviewed
Aug 6, 2021
zhoxing-ms
reviewed
Aug 6, 2021
andyliuliming
suggested changes
Aug 8, 2021
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
zhoxing-ms
reviewed
Aug 10, 2021
Comment on lines
+129
to
+136
| def get_cmd_test_hook_data(filename): | ||
| hook_data = "" | ||
| curr_dir = os.path.dirname(os.path.realpath(__file__)) | ||
| test_hook_file_path = os.path.join(curr_dir, 'tests/latest/data', filename) | ||
| if os.path.exists(test_hook_file_path): | ||
| with open(test_hook_file_path, "r") as f: | ||
| hook_data = json.load(f) | ||
| return hook_data |
Contributor
There was a problem hiding this comment.
Just a little curious, what is the function of this file?
Member
Author
There was a problem hiding this comment.
During testing, the test case will create a hook file. If this file is detected in the corresponding command implementation, it will perform some different operations than usual.
At present, the above process is only used in the aks browse sub-command and the corresponding test_aks_browse_legacy test case. Since the command implementation of aks browse will never exit by default (exit via CTRL+C), this method is used to add a timeout option to the command to exit after a preset period of time during testing.
andyliuliming
approved these changes
Aug 10, 2021
zhoxing-ms
approved these changes
Aug 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update test related command output.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.