[AKS] az aks install-cli: Add support for kubelogin darwin/arm64 releases#19072
Merged
zhoxing-ms merged 2 commits intoAzure:devfrom Aug 9, 2021
Volatus:add-kubelogin-arm64-support
Merged
[AKS] az aks install-cli: Add support for kubelogin darwin/arm64 releases#19072zhoxing-ms merged 2 commits intoAzure:devfrom Volatus:add-kubelogin-arm64-support
az aks install-cli: Add support for kubelogin darwin/arm64 releases#19072zhoxing-ms merged 2 commits intoAzure:devfrom
Volatus:add-kubelogin-arm64-support
Conversation
|
Thank you for your contribution Volatus! We will review the pull request and get back to you soon. |
Collaborator
|
AKS |
Contributor
|
@Volatus Could you please help to fix the style issue? |
Contributor
Author
Done. |
zhoxing-ms
approved these changes
Aug 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the
az aks install-clidoes not work on M1 Macs (darwin/arm64) due to the fact that the wrong release ofkubeloginis being used. I have recently merged this PR which addsarm64builds forkubelogin. The change here adds a check to make sure the right arch is used on the Darwin platform.Testing Guide
az aks install-clion an M1 Mac.History Notes
Fixes #18993
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.