{Security} Update security module to track 2 sdk#18837
Merged
Conversation
Collaborator
|
security |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
evelyn-ys
reviewed
Aug 9, 2021
|
|
||
| for loc in client.locations.list(): | ||
| client.config.asc_location = loc.name | ||
| client._config.asc_location = loc.name |
Member
There was a problem hiding this comment.
Suggested change
| client._config.asc_location = loc.name | |
| client._config.asc_location = loc.name # pylint: disable=protected-access |
jsntcy
reviewed
Aug 12, 2021
|
|
||
| if assessed_resource_id is None: | ||
| assessed_resource_id = '/subscriptions/' + client.config.subscription_id | ||
| assessed_resource_id = '/subscriptions/' + client._config.subscription_id # pylint: disable=protected-access |
Member
There was a problem hiding this comment.
Use
from azure.cli.core.commands.client_factory import get_subscription_id
subscription_id = get_subscription_id(cmd.cli_ctx)to replace client._config.subscription_id
and remove # pylint: disable=protected-access
Also remember add cmd parameter in def list_security_sub_assessments
jsntcy
reviewed
Aug 12, 2021
|
|
||
| if assessed_resource_id is None: | ||
| assessed_resource_id = '/subscriptions/' + client.config.subscription_id | ||
| assessed_resource_id = '/subscriptions/' + client._config.subscription_id # pylint: disable=protected-access |
jsntcy
reviewed
Aug 12, 2021
|
|
||
|
|
||
| def _get_va_sql_api_version(): | ||
| # def _get_va_sql_api_version(): |
jsntcy
approved these changes
Aug 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is to update the security module to track 2 sdk
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.