Skip to content

[AKS] sdk update#18031

Merged
fengzhou-msft merged 10 commits intoAzure:devfrom
haitch:haitao/aks-sdk-update
May 12, 2021
Merged

[AKS] sdk update#18031
fengzhou-msft merged 10 commits intoAzure:devfrom
haitch:haitao/aks-sdk-update

Conversation

@haitch
Copy link
Copy Markdown
Contributor

@haitch haitch commented May 11, 2021 •
edited
Loading

Description

To bump AKS SDK dependency version, future PR will consume this newer version of SDK.

Testing Guide

update all recordings, existing test are working fine.

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

@haitch haitch changed the title Haitao/aks sdk update [AKS] sdk update May 11, 2021
@northtyphoon
Copy link
Copy Markdown
Member

northtyphoon commented May 11, 2021

@haitch, does the pr include any change related to ACR? If yes, can you point me to the code?

@haitch
Copy link
Copy Markdown
Contributor Author

haitch commented May 11, 2021

@haitch, does the pr include any change related to ACR? If yes, can you point me to the code?

nevermind, the initial version have ACR recording file updated as well, I reverted those.

@fengzhou-msft fengzhou-msft merged commit 5434b87 into Azure:dev May 12, 2021
@xfz11
Copy link
Copy Markdown
Contributor

xfz11 commented May 13, 2021

Hi, the PR caused aks-preview extension test failed. Pls take a look

@FumingZhang
Copy link
Copy Markdown
Member

FumingZhang commented May 14, 2021

@haitch, @xfz11 the updated sdk version (11.2.0) make delete request with api version 2021-03-01 now, however the recordings in aks-preview records request with api version 2021-02-01. So this pr change is breaking aks-preview tests

@FumingZhang FumingZhang mentioned this pull request May 14, 2021
Merged
15 tasks
@xfz11
Copy link
Copy Markdown
Contributor

xfz11 commented May 14, 2021

@yungezz

@yungezz
Copy link
Copy Markdown
Member

yungezz commented May 14, 2021

@haitch, @xfz11 the updated sdk version (11.2.0) make delete request with api version 2021-03-01 now, however the recordings in aks-preview records request with api version 2021-02-01. So this pr change is breaking aks-preview tests

hi @haitch this PR caused Azure CLI extension repo CI test failed, it blocks PRs in extension repo. Could you pls fix aks extension tests to make CI pass?

@haitch
Copy link
Copy Markdown
Contributor Author

haitch commented May 14, 2021

We have a fix PR pending to be merged: Azure/azure-cli-extensions#3378

@haitch, @xfz11 the updated sdk version (11.2.0) make delete request with api version 2021-03-01 now, however the recordings in aks-preview records request with api version 2021-02-01. So this pr change is breaking aks-preview tests

hi @haitch this PR caused Azure CLI extension repo CI test failed, it blocks PRs in extension repo. Could you pls fix aks extension tests to make CI pass?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@northtyphoon northtyphoon Awaiting requested review from northtyphoon

@yungezz yungezz Awaiting requested review from yungezz

@zqingqing1 zqingqing1 Awaiting requested review from zqingqing1

@evelyn-ys evelyn-ys Awaiting requested review from evelyn-ys

@houk-ms houk-ms Awaiting requested review from houk-ms

@jiasli jiasli Awaiting requested review from jiasli jiasli is a code owner

@jsntcy jsntcy Awaiting requested review from jsntcy

@Juliehzl Juliehzl Awaiting requested review from Juliehzl

1 more reviewer

@fengzhou-msft fengzhou-msft fengzhou-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@haitch @northtyphoon @xfz11 @FumingZhang @yungezz @fengzhou-msft