[AppService] webapp log tail Fix #17987: logging.warning call with invalid 'end' argument#17988
Merged
[AppService] webapp log tail Fix #17987: logging.warning call with invalid 'end' argument#17988
webapp log tail Fix #17987: logging.warning call with invalid 'end' argument#17988Conversation
|
Thank you for your contribution npazosmendez! We will review the pull request and get back to you soon. |
npazosmendez
commented
May 6, 2021
| .encode(std_encoding, errors='replace') | ||
| .decode(std_encoding, errors='replace'), end='') # each line of log has CRLF. | ||
| .decode(std_encoding, errors='replace') | ||
| .rstrip('\n\r')) # each line of log has CRLF. |
Contributor
Author
There was a problem hiding this comment.
.rstrip('\n\r') might remove newlines which were intentionally logged by the app, so this is probably not ideal. But I don't know what line terminator is the extra one: \n, \r, \r\n?
From what I've seen, it seems to be \n. So replacing rstrip with [:-1] should do the job, as long as it is guaranteed that there will always be a trailing newline.
qwordy
approved these changes
May 7, 2021
This was referenced May 11, 2021
|
when will this fix be live ? |
Contributor
Author
@Json2CSharp according to this comment, on 05/25/2021. |
This was referenced May 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #17987