Skip to content

[AppService] BREAKING CHANGE: az webapp list-runtimes: Add Dotnet6 support and update runtimes#17967

Merged
qwordy merged 3 commits intoAzure:devfrom
calvinsID:dotnet-6
May 12, 2021
Merged

[AppService] BREAKING CHANGE: az webapp list-runtimes: Add Dotnet6 support and update runtimes#17967
qwordy merged 3 commits intoAzure:devfrom
calvinsID:dotnet-6

Conversation

@calvinsID
Copy link
Copy Markdown
Contributor

@calvinsID calvinsID commented May 5, 2021

Description
Fixes #17950

  • Add .NET 6 support for AppService webapps. Runtime dotnet|6.0 can be used with az webapp create and az webapp up
  • Values are hardcoded, since stacks API is in 2020-12-01 api version

Update runtimes:

  • Remove php|7.2, java|1.8|tomcat|8.0, java|11|tomcat|8.0, java|7|tomcat 7 , 8.5, 9, SE for windows
  • Add node|14-lts for windows
  • Remove php|7.2 for linux
  • Add java JBOSSEAP for linux

Testing Guide

  • az webapp list-runtimes (--linux) should show dotnet|6.0 as an available runtime
  • az webapp up run in a .NET6 app should work and create a dotnet|6.0 webapp
  • az webapp create --runtime "dotnet|6.0" should create a dotnet|6.0 webapp

This checklist is used to make sure that common guidelines for a pull request are followed.

@calvinsID calvinsID requested review from Juliehzl and qwordy as code owners May 5, 2021 15:19
@calvinsID calvinsID requested review from btardif and panchagnula May 5, 2021 15:20
@calvinsID calvinsID added this to the S187 milestone May 5, 2021
Copy link
Copy Markdown
Contributor

@panchagnula panchagnula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@btardif btardif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope I'm misunderstanding something but .NET 5 should not be removed. It's still a valid stack

@qwordy
Copy link
Copy Markdown
Member

qwordy commented May 12, 2021

@calvinsID Ready to merge?

@calvinsID
Copy link
Copy Markdown
Contributor Author

@calvinsID Ready to merge?

@qwordy yes pls!

@qwordy qwordy merged commit dd33467 into Azure:dev May 12, 2021
@qwordy
Copy link
Copy Markdown
Member

qwordy commented May 12, 2021

@calvinsID, is it still a breaking change since you changed default back to .NET5?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webapp:.NET 6 support for Runtime Versions

4 participants