[AKS] az aks check-acr: add the nodeslector linux to avoid the "canipull" pod to be scheduled on the windows node#17933
Merged
fengzhou-msft merged 1 commit intoAzure:devfrom May 8, 2021
Conversation
…on the windows node
|
Thank you for your contribution Shuanglu! We will review the pull request and get back to you soon. |
fengzhou-msft
approved these changes
May 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
referring to the issue #17930 , the command will timeout when the "canipull" pod is scheduled on the windows node. The windows node doesn't support host network mode hence the pod will get stuck in container creating
https://kubernetes.io/docs/setup/production-environment/windows/intro-windows-in-kubernetes/#networking-limitations
Testing Guide
Example usage: az aks check-acr -g -n --acr xx.azurecr.io
Example YAML of "canipull" pod:
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.