Skip to content

{PrivateDns} Track 2 Migration#17882

Merged
jsntcy merged 15 commits intoAzure:devfrom
rajitaaa:raghosal-privatedns
May 12, 2021
Merged

{PrivateDns} Track 2 Migration#17882
jsntcy merged 15 commits intoAzure:devfrom
rajitaaa:raghosal-privatedns

Conversation

@rajitaaa
Copy link
Copy Markdown
Contributor

@rajitaaa rajitaaa commented Apr 26, 2021

Description

Changes made for track 2 migration:

Model:
RecordSetPaged --> RecordSetListResult
Methods:
delete ---> begin_delete
update ---> begin_update
create_or_update ---> begin_create_or_update
Exception:
CloudError ---> HttpResponseError and ResourceNotFoundError
Removed unnecessary subitems for:
operations_tmpl='azure.mgmt.privatedns.operations#PrivateZonesOperations.{}
operations_tmpl='azure.mgmt.privatedns.operations#VirtualNetworkLinksOperations.{}
operations_tmpl='azure.mgmt.privatedns.operations#RecordSetsOperations.{}

Updated privatedns package to https://pypi.org/project/azure-mgmt-privatedns/1.0.0/

Testing Guide

History Notes


This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan yonzhan added this to the S186 milestone Apr 27, 2021
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Apr 27, 2021

PrivateDns

@jsntcy
Copy link
Copy Markdown
Member

jsntcy commented Apr 27, 2021

@rajitaaa, please resolve the conflict.
Other parts LGTM.

@yonzhan yonzhan modified the milestones: S186, S187 May 1, 2021
Co-authored-by: Yu Chen <ychenu@microsoft.com>
Copy link
Copy Markdown
Member

@fengzhou-msft fengzhou-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes in patch_models.py LGTM.

@jsntcy jsntcy merged commit 5c08010 into Azure:dev May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants