{Core} Aladdin recommendation improvements#17854
Merged
Conversation
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
fengzhou-msft
approved these changes
Apr 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR provides two improvements for Aladdin recommendation
1. When users input duplicated parameters, we take only a distinct set of parameters and send them to Aladdin service.
For example, when user inputs
az group create -g rg1 -g rg2 -g rg3, the parameters we send to Aladdin is[--resource-group], not[--resource-group, --resource-group, --resource-group]. Otherwise, aladdin service may throwQuery Too Longerror.Even for the cases where multiple same parameters may make sense, the change won't affect the recommendation result.
2. Handle the cases where descriptions may not be provided for sample commands in help.py
Otherwise, the recommendation will just fail.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.