[Compute] disk create: Trusted launch; [Compute] disk create: Hibernation#17775
Merged
[Compute] disk create: Trusted launch; [Compute] disk create: Hibernation#17775
Conversation
xfz11
reviewed
Apr 21, 2021
|
|
||
| if hyper_v_generation: | ||
| disk.hyper_vgeneration = hyper_v_generation | ||
| disk.hyper_v_generation = hyper_v_generation |
Contributor
There was a problem hiding this comment.
It seems that there are still many unnoticed but ubiquitous attribute/model/function-name error caused by track2 upgrading.
Is it necessary to check them thoroughly in advance rather than fix them after issues raising?
Member
Author
There was a problem hiding this comment.
You are right. It is a disadvantage of dynamic language. We can't detect the error until runtime.
houk-ms
approved these changes
Apr 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolve #17656
Resolve #17599
disk create, 2 new parameters, --security-type, --support-hibernation
Fix a field name error. It is caused by a SDK breaking change.
hyper_vgenerationbecamehyper_v_generationTesting Guide
History Notes
[Compute] disk create: Trusted launch
[Compute] disk create: Hibernation
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.