[BACKUP] az backup vault create: Add tags as an optional argument#17735
Merged
[BACKUP] az backup vault create: Add tags as an optional argument#17735
Conversation
qwordy
reviewed
Apr 19, 2021
| c.argument('location', validator=get_default_location_from_resource_group) | ||
|
|
||
| with self.argument_context('backup vault create') as c: | ||
| c.argument('tags', type=file_type, help='JSON encoded tags. Use the show command with JSON output to see tags format. Modify the values accordingly using a file editor and pass the file path here.', completer=FilesCompleter()) |
Member
There was a problem hiding this comment.
You can also consider
tags_type = CLIArgumentType(
validator=validate_tags,
help="space-separated tags: key[=value] [key[=value] ...]. {}".format(quote_text),
nargs='*'
)
tag_type = CLIArgumentType(
type=validate_tag,
help="a single tag in 'key[=value]' format. {}".format(quote_text),
nargs='?',
const=''
)
qwordy
approved these changes
Apr 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added tags as an optional argument to az backup vault create command. Now the users will be able to create vaults with tags by giving space-separated tags as command-line arguments.
Testing Guide
az backup vault create -n {vault_name} --location {location_name} -g {rg_name} --tags DeleteBy=12-9999 Owner=akneema
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.