[ACR] Fix #17618: Update credential add/update handling for tasks created using --auth-mode#17715
Merged
fengzhou-msft merged 2 commits intoAzure:devfrom Apr 26, 2021
Merged
Conversation
yungezz
approved these changes
Apr 16, 2021
fengzhou-msft
approved these changes
Apr 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #17618.
Fixes the sample for creating a task with
--auth-mode None.Testing Guide
--auth-modevalue.az acr task create -t hello-world:{{.Run.ID}} -n hello-world -r MyRegistry -f Dockerfile \ --no-push true --auth-mode None -c https://github.com/Azure-Samples/acr-build-helloworld-node.git \ --git-access-token 000000000000000000000000000000000 --assign-identityaz acr task credential add --login-server myotherregistry.azurecr.io --use-identity [system]Previously,
az acr task credential addandaz acr task credential updatecrashed.History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.