Skip to content

[FunctionApp] Updated stacks api json to add PowerShell on Linux in Functions#17678

Merged
qwordy merged 4 commits intoAzure:devfrom
stefanushinardi:azure-functions-add-powershell-linux
Apr 19, 2021
Merged

[FunctionApp] Updated stacks api json to add PowerShell on Linux in Functions#17678
qwordy merged 4 commits intoAzure:devfrom
stefanushinardi:azure-functions-add-powershell-linux

Conversation

@stefanushinardi
Copy link
Copy Markdown
Contributor

@stefanushinardi stefanushinardi commented Apr 14, 2021

Description

The PR is to add Powershell on linux offerings #17657
Testing Guide

Verified that now the command does not throw validation error when deploying with Linux os type. And also verified creation of both consumption and elastic premium plan

sample command:

az functionapp create --name powershell-linux-premium-cli-create-shinardi --os-type Linux --runtime powershell --resource-group powershell-linux-cli-shinardi --functions-version 3 --storage-account powershelllinuxcli --plan ASP-pythonscaling-8a67

Application Insights "powershell-linux-premium-cli-create-shinardi" was created for this Function App. You can visit https://portal.azure.com/#resource/subscriptions/df6d3c16-321b-4f5b-a9de-c4ed04950b97/resourceGroups/powershell-linux-cli-shinardi/providers/microsoft.insights/components/powershell-linux-premium-cli-create-shinardi/overview to view your Application Insights component

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

@stefanushinardi
Copy link
Copy Markdown
Contributor Author

stefanushinardi commented Apr 14, 2021

cc: @Francisco-Gamino @AnatoliB @pragnagopa @gzuber Please review this PR. Thanks!

@yungezz yungezz added the Functions az functionapp label Apr 14, 2021
pragnagopa
pragnagopa reviewed Apr 14, 2021
View reviewed changes
src/azure-cli/azure/cli/command_modules/appservice/resources/LinuxFunctionsStacks.json Outdated
},
"isPreview": false,
"isDeprecated": false,
"isHidden": false
Copy link
Copy Markdown
Member

@pragnagopa pragnagopa Apr 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use: https://github.com/pragnagopa/azure-functions-supported-runtime-stacks/blob/master/LinuxFunctionsStacks.json

We want this stack to be hidden until we roll out functions host changes to support linux consumption

pragnagopa
pragnagopa suggested changes Apr 14, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@pragnagopa pragnagopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add stack as hidden. Also, need to add tests that check powershell stack

@gzuber
Copy link
Copy Markdown
Member

gzuber commented Apr 14, 2021

Please add stack as hidden. Also, need to add tests that check powershell stack

Hey @stefanushinardi I sent you a message about the tests, let me know if I can help out! 😄

@stefanushinardi
Copy link
Copy Markdown
Contributor Author

stefanushinardi commented Apr 16, 2021

@pragnagopa @gzuber Added that tests for powershell. Thanks @Hazhzeng to help fix the local setip

gzuber
gzuber approved these changes Apr 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@gzuber gzuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@qwordy
Copy link
Copy Markdown
Member

qwordy commented Apr 16, 2021

@stefanushinardi Are we ready to merge?

pragnagopa
pragnagopa approved these changes Apr 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@pragnagopa pragnagopa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Thanks @stefanushinardi

@stefanushinardi
Copy link
Copy Markdown
Contributor Author

stefanushinardi commented Apr 16, 2021

@qwordy yup, thanks!

@qwordy qwordy merged commit 9362079 into Azure:dev Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Juliehzl Juliehzl Awaiting requested review from Juliehzl

4 more reviewers

@pragnagopa pragnagopa pragnagopa approved these changes

@qwordy qwordy qwordy approved these changes

@yungezz yungezz yungezz approved these changes

@gzuber gzuber gzuber approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@qwordy qwordy

Labels

Functions az functionapp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stefanushinardi @gzuber @qwordy @pragnagopa @yungezz