[Compute] vm create --count mode, support vnet and subnet configuration#17660
[Compute] vm create --count mode, support vnet and subnet configuration#17660
Conversation
houk-ms
left a comment
There was a problem hiding this comment.
Can you link your PR which supports the --count parameter here? I have no context why we need remove the lines in the validation function.
| namespace.public_ip_address_dns_name, | ||
| namespace.storage_account, | ||
| namespace.storage_container_name, | ||
| namespace.subnet, |
There was a problem hiding this comment.
Because I disabled it. Now I decide to enable it.
|
the change itself LGTM, is there any test on --count, to expand coverage of those params? |
I should double all vm test with only one difference "--count". I give up. |
At least |
Description
Resolve #17649
Support --vnet-name, --subnet
Example (3) can work in current version of Azure CLI. Example (1) (2) will work on 5/4/2021. We need to be aware of "az vm create" does not support full functionality of vnet and subnet creation. Use "az network vnet" to create vnet and subnet if you'd like to control all configuration.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.