[ARM] BREAKING CHANGE: az bicep build/decompile: Change the --files parameter to --file#17547
Conversation
|
ARM |
| _config_dir = get_config_dir() | ||
| _bicep_installation_dir = os.path.join(_config_dir, "bin") | ||
| _bicep_version_check_file_path = os.path.join(_config_dir, "bicepVersionCheck.json") | ||
| _bicep_version_check_cache_ttl = timedelta(minutes=10) |
There was a problem hiding this comment.
May I ask why the ttl of this cache is 10 minutes?
There was a problem hiding this comment.
Setting ttl to 10 minutes means it will sent at most 6 requests per hour, which is good enough to avoid GitHub throttling for anonymous requests (60 / hour / IP address). Other other hand, we do want the bicep commands to detect version upgrade of Bicep CLI as soon as we do a release, and I feel like 10 minute of delay is acceptable.
There was a problem hiding this comment.
This is still a workaround, though. CI/CD runs that depend on Bicep can still get throttled. We are also thinking about setting up CDN for caching the Bicep releases to completely eliminate the throttling issue.
I would like to ask why you do not support multiple files any more? |
Because for |
Description
--filesparameter to--fileto only take one file for theaz bicep build/decompilecommands, because we removed the support of multi-file compiling/decompiling support from Bicep CLI. Closes Output directory support for az cli bicep module bicep#2010.Testing Guide
az bicep build/decompile --file {bicep_file}History Notes
[ARM] BREAKING CHANGE: az bicep build: Change the parameter --files to --file
[ARM] BREAKING CHANGE: az bicep decompile: Change the parameter --files to --file
[ARM] az bicep build: Add a parameter --outdir for specifying the output directory
[ARM] az bicep build: Add a parameter --outfile for specifying the output file path
[ARM] Fix an issue where checking version upgrade for Bicep CLI throws exception if GitHub API rate limit is hit
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.