[Network]az network vnet-gateway: --vpn-auth-type allow multi value#17505
Merged
[Network]az network vnet-gateway: --vpn-auth-type allow multi value#17505
az network vnet-gateway: --vpn-auth-type allow multi value#17505Conversation
Collaborator
|
Network |
…-p2s-multi-auth-2021-03-19
kairu-ms
reviewed
Mar 31, 2021
Comment on lines
+6382
to
+6383
| VpnClientRootCertificate(name=root_cert_name, | ||
| public_cert_data=root_cert_data)] if root_cert_data else None |
Contributor
There was a problem hiding this comment.
Do we need to throw error if user provide rout_cert_data but forget root_cert_name?
Member
Author
There was a problem hiding this comment.
root_cert_data is necessary while root_cert_name is not.
kairu-ms
reviewed
Mar 31, 2021
Comment on lines
+6423
to
+6425
| if root_cert_data and cmd.supported_api_version(min_api='2020-11-01'): | ||
| upsert_to_collection(instance.vpn_client_configuration, 'vpn_client_root_certificates', | ||
| VpnClientRootCertificate(name=root_cert_name, public_cert_data=root_cert_data), 'name') |
kairu-ms
approved these changes
Apr 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#17260
#17482
Testing Guide
test_network_vnet_gateway_multi_auth
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.