[Search] Introduce async options for service and shared-private-link-resource commands by jqhuangonearth · Pull Request #17446 · Azure/azure-cli

jqhuangonearth · 2021-03-25T04:16:05Z

Description
Introduce async (--no-wait) options for search service and search shared-private-link-resource commands;

Testing Guide
N/A

History Notes
[Search] az search service create: Add async (--no-wait) options.
[Search] az search service update: Add async (--no-wait) options.
[Search] az search shared-private-link-resource create: Add async (--no-wait) options.
[Search] az search shared-private-link-resource update: Add async (--no-wait) options.

This checklist is used to make sure that common guidelines for a pull request are followed.

[x ] The PR title and description has followed the guideline in Submitting Pull Requests.
[ x] I adhere to the Command Guidelines.
[ x] I adhere to the Error Handling Guidelines.

Merge Azure/azure-cli to my fork

Merge from base

…h as public ip rules, private endpoints, private link resources and msi; also add search provider in 'az network private-link-resource list'

…version; add corresponding tests

Merge from base

Pull from base

…-resource create'

yonzhan · 2021-03-25T09:08:02Z

Search

jqhuangonearth · 2021-03-25T17:45:23Z

@kairu-ms, any idea why the Azure.azure-cli check is always waiting for status to be reported? Is there an pipeline outage?

kairu-ms · 2021-03-25T23:57:37Z

/azp run

azure-pipelines · 2021-03-25T23:57:52Z

Azure Pipelines successfully started running 2 pipeline(s).

kairu-ms · 2021-03-26T00:03:56Z

@kairu-ms, any idea why the Azure.azure-cli check is always waiting for status to be reported? Is there an pipeline outage?

Our pipeline needs manual trigger now, because it was attacked several weeks ago.

kairu-ms

You should add no_wait parameter in custom function signature and use sdk_no_wait to call LongRuningOperation. You can follow this example:

azure-cli/src/azure-cli/azure/cli/command_modules/monitor/operations/log_analytics_workspace_linked_service.py

Lines 9 to 17 in ee405d3

    
           def create_log_analytics_workspace_linked_service(client, resource_group_name, workspace_name, 
        
                                                             linked_service_name, resource_id=None, write_access_resource_id=None, 
        
                                                             no_wait=False): 
        
               from azure.mgmt.loganalytics.models import LinkedService 
        
               linked_service = LinkedService(resource_id=resource_id, 
        
                                              write_access_resource_id=write_access_resource_id) 
        
               return sdk_no_wait(no_wait, client.begin_create_or_update, resource_group_name, 
        
                                  workspace_name, linked_service_name, linked_service)

Merge from base

jqhuangonearth · 2021-03-30T21:04:09Z

You should add no_wait parameter in custom function signature and use sdk_no_wait to call LongRuningOperation. You can follow this example:

azure-cli/src/azure-cli/azure/cli/command_modules/monitor/operations/log_analytics_workspace_linked_service.py

Lines 9 to 17 in ee405d3

def create_log_analytics_workspace_linked_service(client, resource_group_name, workspace_name,

linked_service_name, resource_id=None, write_access_resource_id=None,

no_wait=False):

from azure.mgmt.loganalytics.models import LinkedService

linked_service = LinkedService(resource_id=resource_id,

write_access_resource_id=write_access_resource_id)

return sdk_no_wait(no_wait, client.begin_create_or_update, resource_group_name,

workspace_name, linked_service_name, linked_service)

This is done.

jqhuangonearth · 2021-03-30T22:41:07Z

@kairu-ms, why is it failed when the LINT is [PASSED]: https://dev.azure.com/azure-sdk/public/_build/results?buildId=813902&view=logs&j=168ccbe3-da49-5c0b-6478-08f7016e4bf5&t=10a595be-4223-5cc7-9a73-012871b6eaee

kairu-ms · 2021-03-31T02:11:24Z

You miss help for some commands. Please see logs for details.

jqhuangonearth · 2021-03-31T06:38:11Z

You miss help for some commands. Please see logs for details.

Gotcha. Will fix shortly.

jqhuangonearth · 2021-04-01T18:23:36Z

/azp run

azure-pipelines · 2021-04-01T18:23:51Z

Azure Pipelines successfully started running 2 pipeline(s).

jqhuangonearth · 2021-04-01T21:40:12Z

@kairu-ms, all checks are passed and the change is ready to merge.

huangbolun added 17 commits January 19, 2021 13:20

Merge pull request #1 from Azure/dev

38d450c

Merge Azure/azure-cli to my fork

Merge pull request #2 from Azure/dev

a4a0603

Merge from base

upgrade az search to use the latest sdk version with new features suc…

045ea3d

…h as public ip rules, private endpoints, private link resources and msi; also add search provider in 'az network private-link-resource list'

fix update endpoint to use the begin_create_or_update in the new sdk …

a52dc25

…version; add corresponding tests

fix the azure-cli requirements

359126e

fix the test failure; fix style and liner

9f2b929

fix the public-network-access param; fix cli liner

d64f013

add actions-required param when updating pe connection

8030b2e

address comments to follow best-practise naming conventions

6ec5e96

fix CLI style

59c16dd

disable pylint too-manage-arguments

d74dc7f

fix build failure

6013515

resolve merge conflicts

ad40dec

Merge pull request #5 from Azure/dev

c660ed7

Merge from base

fix the help manual for identity_type

df08063

Merge pull request #6 from Azure/dev

feb84a4

Pull from base

support --no-wait for 'search create' and 'search shared-private-link…

ac87ef2

…-resource create'

jqhuangonearth requested a review from kairu-ms as a code owner March 25, 2021 04:16

jqhuangonearth self-assigned this Mar 25, 2021

jqhuangonearth requested review from arv100kri and yangyuan March 25, 2021 04:17

yonzhan assigned kairu-ms Mar 25, 2021

yonzhan added this to the S185 milestone Mar 25, 2021

yonzhan requested a review from jiasli March 25, 2021 23:40

kairu-ms requested changes Mar 26, 2021

View reviewed changes

huangbolun added 2 commits March 30, 2021 12:21

Merge pull request #7 from Azure/dev

2e65f07

Merge from base

use sdk_no_wait util to invoke async operations

d057f82

jqhuangonearth closed this Mar 30, 2021

jqhuangonearth reopened this Mar 30, 2021

remove unused parameters in update_search_service

f6b0aaf

kairu-ms approved these changes Mar 31, 2021

View reviewed changes

add missing help

32ebd7b

kairu-ms merged commit 885be54 into Azure:dev Apr 1, 2021

	def create_log_analytics_workspace_linked_service(client, resource_group_name, workspace_name,
	linked_service_name, resource_id=None, write_access_resource_id=None,
	no_wait=False):
	from azure.mgmt.loganalytics.models import LinkedService

	linked_service = LinkedService(resource_id=resource_id,
	write_access_resource_id=write_access_resource_id)
	return sdk_no_wait(no_wait, client.begin_create_or_update, resource_group_name,
	workspace_name, linked_service_name, linked_service)

Conversation

jqhuangonearth commented Mar 25, 2021

Uh oh!

yonzhan commented Mar 25, 2021

Uh oh!

jqhuangonearth commented Mar 25, 2021

Uh oh!

kairu-ms commented Mar 25, 2021

Uh oh!

azure-pipelines bot commented Mar 25, 2021

Uh oh!

kairu-ms commented Mar 26, 2021

Uh oh!

kairu-ms left a comment

Choose a reason for hiding this comment

Uh oh!

jqhuangonearth commented Mar 30, 2021

Uh oh!

jqhuangonearth commented Mar 30, 2021

Uh oh!

kairu-ms commented Mar 31, 2021

Uh oh!

jqhuangonearth commented Mar 31, 2021

Uh oh!

jqhuangonearth commented Apr 1, 2021

Uh oh!

azure-pipelines bot commented Apr 1, 2021

Uh oh!

jqhuangonearth commented Apr 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants