Skip to content

[Storage] az storage fs file list: Support --show-next-marker#17408

Merged
evelyn-ys merged 14 commits intoAzure:devfrom
evelyn-ys:fs_file_marker
Mar 29, 2021
Merged

[Storage] az storage fs file list: Support --show-next-marker#17408
evelyn-ys merged 14 commits intoAzure:devfrom
evelyn-ys:fs_file_marker

Conversation

@evelyn-ys
Copy link
Copy Markdown
Member

@evelyn-ys evelyn-ys commented Mar 23, 2021

Description

Feature requested by #16893

Testing Guide

  • Before: Next_Marker only shows in warning message
> az storage fs file list -f ysfs --account-name yssaadls --num-results 1
Next Marker:
VBbOzIiisIvWrR4YOhg1L3lzc2FhZGxzATAxRDcxNjRFQzY2RDRGRjYveXNmcwEwMUQ3MTY0RjMxNjQyNDM1L2RpcjEWAAAA
[
  {
    "contentLength": 12,
    "etag": "0x8D8E9B5A72D28B0",
    "group": "$superuser",
    "isDirectory": false,
    "lastModified": "2021-03-18T02:29:27",
    "name": "123.txt",
    "owner": "$superuser",
    "permissions": "rw-r-----"
  }
]
  • After: Next_Marker shows in results
> az storage fs file list -f ysfs --account-name yssaadls --num-results 1 --show-next-marker
[
  {
    "contentLength": 12,
    "etag": "0x8D8E9B5A72D28B0",
    "group": "$superuser",
    "isDirectory": false,
    "lastModified": "2021-03-18T02:29:27",
    "name": "123.txt",
    "owner": "$superuser",
    "permissions": "rw-r-----"
  },
  {
    "nextMarker": "VBbOzIiisIvWrR4YOhg1L3lzc2FhZGxzATAxRDcxNjRFQzY2RDRGRjYveXNmcwEwMUQ3MTY0RjMxNjQyNDM1L2RpcjEWAAAA"
  }
]

This checklist is used to make sure that common guidelines for a pull request are followed.

@evelyn-ys evelyn-ys self-assigned this Mar 23, 2021
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Mar 23, 2021

Storage

@yonzhan yonzhan added this to the S185 milestone Mar 23, 2021
Juliehzl
Juliehzl reviewed Mar 25, 2021
View reviewed changes
src/azure-cli/azure/cli/command_modules/storage/_params.py Outdated
help='An opaque continuation token. This value can be retrieved from the next_marker field of a '
'previous generator object. If specified, this generator will begin returning results from this '
'point.')
c.argument('show_next_marker', action='store_true',
Copy link
Copy Markdown
Contributor

@Juliehzl Juliehzl Mar 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add preview for the flag in this sprint?

Copy link
Copy Markdown
Member Author

@evelyn-ys evelyn-ys Mar 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Done~

@evelyn-ys evelyn-ys requested a review from Juliehzl March 26, 2021 03:03
@evelyn-ys evelyn-ys merged commit f331b03 into Azure:dev Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Juliehzl Juliehzl Juliehzl approved these changes

@jsntcy jsntcy Awaiting requested review from jsntcy jsntcy is a code owner

@zhoxing-ms zhoxing-ms Awaiting requested review from zhoxing-ms

Assignees

@evelyn-ys evelyn-ys

Labels

None yet

Projects

None yet

Milestone

S185

Development

Successfully merging this pull request may close these issues.

3 participants

@evelyn-ys @yonzhan @Juliehzl