Skip to content

[AKS] Fix cross-sub assigning identity error and attach acr error#17281

Merged
fengzhou-msft merged 4 commits intoAzure:devfrom
norshtein:tosi/aks-fix-sub
Mar 16, 2021
Merged

[AKS] Fix cross-sub assigning identity error and attach acr error#17281
fengzhou-msft merged 4 commits intoAzure:devfrom
norshtein:tosi/aks-fix-sub

Conversation

@norshtein
Copy link
Copy Markdown
Member

Description

This PR fixes two errors:

  • Currently, the MSI client is created using current context's subscription, which is incorrect when the identity is in another subscription.
  • The checking for MSI cluster is incorrect when attaching ACR, type "UserAssigned" managed cluster is not treated as MSI cluster.

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@yungezz yungezz added the AKS az aks/acs/openshift label Mar 12, 2021
@fengzhou-msft fengzhou-msft merged commit 960c8e7 into Azure:dev Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS az aks/acs/openshift

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants