Core

I compared the implement before and found that the original way support spinner already. There's just a bug winthin LongRunningOperation. L123 shows that cli_ctx.get_progress_controller() will init progress and create a new spinner each time when called.

LRO calls self.cli_ctx.get_progress_controller().begin(), self.cli_ctx.get_progress_controller().add(message='Running') or self.cli_ctx.get_progress_controller().end() to update progress. But each time updating the progress, the progress will be initialized. So the behavior will look like no animation.

To support spinning for LRO, we only need to log progress_controller = self.cli_ctx.get_progress_controller() and then call progress_controller.begin(), progress_controller.add(message='Running') and progress_controller.end() within LongRunningOperation.

I compared the implement before and found that the original way support spinner already. There's just a bug winthin LongRunningOperation. L123 shows that cli_ctx.get_progress_controller() will init progress and create a new spinner each time when called.

azure-cli/src/azure-cli-core/azure/cli/core/__init__.py

Lines 118 to 124 in 7d0dd03

	def get_progress_controller(self, det=False):
	import azure.cli.core.commands.progress as progress
	if not self.progress_controller:
	self.progress_controller = progress.ProgressHook()
	self.progress_controller.init_progress(progress.get_progress_view(det))
	return self.progress_controller

LRO calls self.cli_ctx.get_progress_controller().begin(), self.cli_ctx.get_progress_controller().add(message='Running') or self.cli_ctx.get_progress_controller().end() to update progress. But each time updating the progress, the progress will be initialized. So the behavior will look like no animation.

To support spinning for LRO, we only need to log progress_controller = self.cli_ctx.get_progress_controller() and then call progress_controller.begin(), progress_controller.add(message='Running') and progress_controller.end() within LongRunningOperation.

Yes, there is an issue in previous design. Here I don't use add() because I want to expand progress bar capability with update_progress(), which could have more progress bar UI.