Skip to content

[Storage] Fix #16979: az storage container create fails when providing storage container metadata#17202

Merged
evelyn-ys merged 11 commits intoAzure:devfrom
evelyn-ys:container_metadata
Mar 17, 2021
Merged

[Storage] Fix #16979: az storage container create fails when providing storage container metadata#17202
evelyn-ys merged 11 commits intoAzure:devfrom
evelyn-ys:container_metadata

Conversation

@evelyn-ys
Copy link
Copy Markdown
Member

Description

Fix #16979

az storage container create has command validator validate_client_auth_parameter which will suppress all argument validators including validate_metadata. As a result, metadata can't be parsed properly.

Testing Guide

az storage container create -n testcontainer --metadata k1=v1 k2=v2


This checklist is used to make sure that common guidelines for a pull request are followed.

@evelyn-ys evelyn-ys self-assigned this Mar 4, 2021
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Mar 4, 2021

Storage

@yonzhan yonzhan added this to the S184 milestone Mar 4, 2021
Copy link
Copy Markdown
Contributor

@Juliehzl Juliehzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add --metadata check?

@evelyn-ys evelyn-ys requested a review from Juliehzl March 10, 2021 05:34
@evelyn-ys
Copy link
Copy Markdown
Member Author

Could you add --metadata check?

There's no specialized test for storage container create. So I added --metadata in a test which used storage container create.

@evelyn-ys evelyn-ys merged commit aca6de4 into Azure:dev Mar 17, 2021
@evelyn-ys evelyn-ys deleted the container_metadata branch September 7, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

az storage container create fails when providing storage container metadata

3 participants