[Storage] Support user assigned identity for storage account#16613
Merged
[Storage] Support user assigned identity for storage account#16613
Conversation
Collaborator
|
Storage |
74ecab9 to
bad3b3f
Compare
65de846 to
f21fc0f
Compare
10d8851 to
77a0871
Compare
evelyn-ys
reviewed
Apr 26, 2021
Comment on lines
+84
to
+89
| if params.encryption.key_source and params.encryption.key_source == "Microsoft.Keyvault": | ||
| if params.encryption.key_vault_properties is None: | ||
| KeyVaultProperties = cmd.get_models('KeyVaultProperties') | ||
| params.encryption.key_vault_properties = KeyVaultProperties(key_name=encryption_key_name, | ||
| key_vault_uri=encryption_key_vault, | ||
| key_version=encryption_key_version) |
Member
There was a problem hiding this comment.
Shall we add
else:
if any([encryption_key_name, encryption_key_vault, encryption_key_version]):
raise ValueError(
'Specify `--encryption-key-source=Microsoft.Keyvault` to configure key vault properties.')like what update_storage_account does
Contributor
Author
There was a problem hiding this comment.
Actually it is by design.
In create scenario, we already have validator for input value as you can see below
azure-cli/src/azure-cli/azure/cli/command_modules/storage/_validators.py
Lines 488 to 497 in 289c238
But in update scenario, we need to consider existing parameter values, so we add an addition check here.
evelyn-ys
approved these changes
Apr 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See https://microsoft-my.sharepoint.com/:w:/p/ozgun/EYc_gSQnco5LkPJI4MYSidsBPSBDRLXpQfFyQtjtXPwsyQ?e=LvWsGk&CID=BFBDB6A6-36D8-4992-81C3-864729996585&wdLOR=cD2686608-0966-4F97-8754-B02974231DAE
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.