{container} Bugfix #15856: az container exec - remove eol check to avoid closing terminal before it even started on linux#16000
Conversation
The backend sends an empty webSocket message after establishing an connection. The removed lines of code interpreted that as an EOL which exits the webSocket read loop. As the Windows code doesn't do that as well, I removed it here as well now. The terminal gets closed after the webSocket closes anyway. Fixes: #15856
|
Thank you for your contribution bitcloud! We will review the pull request and get back to you soon. |
Contributor
Author
|
I'm not quite sure if I should submit that as a hotfix as well to merge that also against the current version? |
Collaborator
|
container |
qwordy
approved these changes
Nov 23, 2020
Contributor
Author
|
Any updates here? Anything else I should do? |
Member
Wait for code owner to review. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
Contributor
|
Actually, I am not the owner of container module, which should be owned by service team. |
Contributor
|
Sorry I'm not the owner either and I am not aware which team is the owner. |
qwordy
approved these changes
Dec 25, 2020
Member
|
@zhoxing-ms Are you willing to be owner of this module? |
zhoxing-ms
approved these changes
Jan 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backend sends an empty webSocket message after establishing an connection. The removed lines of code interpreted that as an EOL which exits the webSocket read loop.
As the Windows code doesn't do that as well, I removed it here as well now.
The terminal gets closed after the webSocket closes anyway.
Fixes: #15856
Description
As described in #15856 there is currently an issue getting a remote terminal to a container instance with
az container execas it immediately closes the connection.Testing Guide
az container createwith a long living containeraz container exec --exec-command "/bin/bash" ...History Notes
[container] az container exec: remove eol check to avoid closing terminal before it even started on linux
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.