[Network] az network lb address-pool: support create lb backend pool with backend address. by mmyyrroonn · Pull Request #13700 · Azure/azure-cli

mmyyrroonn · 2020-05-27T08:21:39Z

Description

fix #12937
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.

yonzhan · 2020-05-27T11:22:06Z

add to S170

yonzhan · 2020-05-31T12:57:04Z

add to S171

haroldrandom · 2020-06-04T01:38:35Z

src/azure-cli/azure/cli/command_modules/network/_validators.py

    del namespace.connection_id
+
+
+def process_vnet_name_or_id(cmd, namespace):


duplicated work?

azure-cli/src/azure-cli/azure/cli/command_modules/network/_validators.py

Lines 86 to 111 in e3b8744

def get_vnet_validator(dest):

from msrestazure.tools import is_valid_resource_id, resource_id

def _validate_vnet_name_or_id(cmd, namespace):

SubResource = cmd.get_models('SubResource')

subscription_id = get_subscription_id(cmd.cli_ctx)

resource_group = namespace.resource_group_name

names_or_ids = getattr(namespace, dest)

ids = []

if names_or_ids == [''] or not names_or_ids:

return

for val in names_or_ids:

if not is_valid_resource_id(val):

val = resource_id(

subscription=subscription_id,

resource_group=resource_group,

namespace='Microsoft.Network', type='virtualNetworks',

name=val

)

ids.append(SubResource(id=val))

setattr(namespace, dest, ids)

return _validate_vnet_name_or_id

I cannot use it since it's a list and SubResource. ids.append(SubResource(id=val))

src/azure-cli/azure/cli/command_modules/network/commands.py

src/azure-cli/azure/cli/command_modules/network/custom.py

jsntcy · 2020-06-09T05:36:53Z

src/azure-cli/azure/cli/command_modules/network/custom.py

+                                                ip_address=addr['ip_address']) for addr in addresses_pool] if addresses_pool else None
+    new_pool = BackendAddressPool(name=backend_address_pool_name,
+                                  load_balancer_backend_addresses=new_addresses)
+    return ncf.load_balancer_backend_address_pools.create_or_update(resource_group_name,


support no wait for LRO?

I prefer keeping it as a sync command since we already supported it for a long time and the speed is quick enough. #Closed

src/azure-cli/azure/cli/command_modules/network/custom.py

src/azure-cli/azure/cli/command_modules/network/_validators.py

src/azure-cli/azure/cli/command_modules/network/custom.py

jsntcy · 2020-06-09T05:53:14Z

src/azure-cli/azure/cli/command_modules/network/custom.py

+    address_pool = client.get(resource_group_name, load_balancer_name, backend_address_pool_name)
+    lb_addresses = [addr for addr in address_pool.load_balancer_backend_addresses if addr.name != address_name]
+    address_pool.load_balancer_backend_addresses = lb_addresses
+    return client.create_or_update(resource_group_name, load_balancer_name, backend_address_pool_name, address_pool)


support no wait?

I prefer keeping it as a sync command. #Closed

src/azure-cli/azure/cli/command_modules/network/_validators.py

src/azure-cli/azure/cli/command_modules/network/_params.py

jsntcy · 2020-06-09T06:05:40Z

src/azure-cli/azure/cli/command_modules/network/_actions.py

+            raise CLIError('usage error: {} [KEY=VALUE ...]'.format(option_string))
+        d = {}
+        for k in properties:
+            kl = k.lower()


Discussion: can we share generic logic for key-value arguments (keep naming the same as SDK parameters)

jsntcy

mmyyrroonn requested a review from haroldrandom as a code owner May 27, 2020 08:21

mmyyrroonn requested a review from jsntcy May 27, 2020 08:21

yonzhan assigned mmyyrroonn May 27, 2020

yonzhan added this to the S170 milestone May 27, 2020

yonzhan modified the milestones: S170, S171 May 31, 2020

MyronFanQiu added 12 commits June 2, 2020 15:46

fix

25fc445

wip

492a74b

init version

2f7b5fd

draft version

cd59210

left three tests and help message

bf38d21

finish

ed276a0

fix linter

a5dd240

support other profiles

6de80db

fix

3241b52

fix

5019664

finish new design

7f08aa6

fix style

14f1bc6

mmyyrroonn force-pushed the fix-12937-support-lb-backend-pool branch from b01de9a to 14f1bc6 Compare June 2, 2020 07:59

haroldrandom reviewed Jun 4, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/network/commands.py Show resolved Hide resolved

haroldrandom reviewed Jun 4, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/network/commands.py Show resolved Hide resolved

haroldrandom approved these changes Jun 4, 2020

View reviewed changes