AppConfig: Support CRUD of feature flags#10774
Merged
Conversation
* FeatureManagement CLI Part 1 FeatureManagement initial code setup and implementation of "show feature" and "set feature" commands * Adding "delete" and "list" feature commands * Adding "set" and "show" feature commands * Add "enable", "disable", "lock", "unlock" commands
* FeatureManagement CLI Part 1 FeatureManagement initial code setup and implementation of "show feature" and "set feature" commands * Adding "delete" and "list" feature commands * Resolving Comments * Add "enable", "disable", "lock", "unlock" commands * Resolving comments * Resolving comments * setup for filter commands * Adding filter commands * Adding Unit Tests * Fix styling issues * test recordings * Update release history * resolving comments * resolving comments * Minor change * Add FeatureFlagValue Model * Validate filter parameters * Fix formatting of _params.py * Change variable names * Log warning when delete filter index mismatch * Resolving comments
Member
Author
|
Please add @shenmuxiaosen as reviewer. #Resolved |
Contributor
|
It looks a breaking change. It will be better for us to have a meeting to go through all your commands. |
Juliehzl
reviewed
Oct 12, 2019
Juliehzl
reviewed
Oct 12, 2019
Juliehzl
reviewed
Oct 16, 2019
Juliehzl
reviewed
Oct 16, 2019
Juliehzl
reviewed
Oct 16, 2019
Juliehzl
reviewed
Oct 16, 2019
Contributor
|
@avanigupta Please resolve my comments and make CI agree. |
shenmuxiaosen
previously approved these changes
Oct 17, 2019
Contributor
shenmuxiaosen
left a comment
There was a problem hiding this comment.
Since we have already done a business logic review in your own repo, this pr looks good to me. Thanks Avani!
Juliehzl
reviewed
Oct 21, 2019
src/azure-cli/azure/cli/command_modules/appconfig/_featuremodels.py
Outdated
Show resolved
Hide resolved
Contributor
|
LGTM. Please consider my last suggestion and resolve the conflict. |
Juliehzl
previously approved these changes
Oct 22, 2019
Juliehzl
approved these changes
Oct 24, 2019
mmyyrroonn
approved these changes
Oct 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.