RG mode: uses azlist with rg included, with special handling for empty rg#574
Merged
magodo merged 1 commit intoAzure:mainfrom Nov 11, 2024
Merged
RG mode: uses azlist with rg included, with special handling for empty rg#574magodo merged 1 commit intoAzure:mainfrom
azlist with rg included, with special handling for empty rg#574magodo merged 1 commit intoAzure:mainfrom
Conversation
ms-henglu
approved these changes
Nov 11, 2024
|
Thank you very much for the super fast fix! 🚀 However, after a first test from the source repo branch, giulio@WPWS19069419:/mnt/c/Dati/golang/aztfy$ git branch -vv
* rg_use_azlist f6bad23 [origin/rg_use_azlist] RG mode: uses `azlist` with rg included, with special handling for empty rgI still can't see the role assignment, what am I missing now? giulio@WPWS19069419:/mnt/c/Dati/golang/aztfy$ ~/go/bin/aztfexport rg --append --include-role-assignment --output-dir tf_
test -n my-rg
giulio@WPWS19069419:/mnt/c/Dati/golang/aztfy$ cat tf_test/main.aztfexport.tfresource "azurerm_resource_group" "res-0" {
location = "westeurope"
name = "my-rg"
}Thanks in advance for your clarification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an improvement on #500, that we leverages the
azlistto include the resource group being listed as part of the resource list. The benefit of this is thatazlistwill pick up any extension resources for the resource list, including the resoruce group itself (which solves the #573). The only thing need special handling is that for empty resource group, the resource group won't be listed, in which case we'll have to manually add the resource group to the resource list.Fix #573